-
Notifications
You must be signed in to change notification settings - Fork 33
New issue: Multidimensional arrays are not supported by <tt>meta::ref… #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2904bea to
13b0560
Compare
…lect_constant_array</tt> and related functions
13b0560 to
8fc9b6b
Compare
xml/issue4483.xml
Outdated
| <del><tt>is_constructible_v<T, ranges::range_reference_t<R>></tt> is `true`, and</del> | ||
| </li> | ||
| <li><ins>(9.2) —</ins> <tt>T</tt> satisfies <tt>copy_constructible</tt><ins>, and</ins></li> | ||
| <li><ins>(9.3) —</ins> <tt>U</tt> does not denote array type, then <tt>is_constructible_v<T, ranges::range_reference_t<R>></tt> is <tt>true</tt>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <li><ins>(9.3) —</ins> <tt>U</tt> does not denote array type, then <tt>is_constructible_v<T, ranges::range_reference_t<R>></tt> is <tt>true</tt>.</li> | |
| <li><ins>(9.3) — if <tt>U</tt> is not an array type, then <tt>is_constructible_v<T, ranges::range_reference_t<R>></tt> is <tt>true</tt>.</ins></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also replace dontes.
Co-authored-by: timsong-cpp <rs2740@gmail.com>
Co-authored-by: timsong-cpp <rs2740@gmail.com>
Co-authored-by: timsong-cpp <rs2740@gmail.com>
xml/issue4483.xml
Outdated
| <li>(11.2) — Otherwise, the template parameter object of type <tt>const array<T, 0></tt> initialized with `{}`.</li> | ||
| </ul></p> | ||
| <p>-12- <i>Returns</i>: <tt>^^<i>P</i></tt>.</p> | ||
| <p>-13- <i>Throws</i>: Any <ins>of</ins> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "any of" construction followed by the item list sounds weird to me. I think about a better formulation. My current proposal would be to replace the item lists by individual sentences each one starting with "Any [...] of ", this seems to be existing practice elsewhere. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On reflector discussion Hubert requested "Any of" to emphasize unspecified nature of which one is selected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not criticizing the usage of "any of" (This is standard formaulation), but the concrete usage here where we use "any of" before as introducer before the bullet list and then expressing each bullet item as a seemingly continuation of this "any of". But a sentence such as "any of exception thrown by increment and dereference operations on iterator to r and comparison of such iterator to sentinel," doesn't sound like a real sentence to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion would be to replace the bullet list by individual sentences roughly as follows:
Any exception thrown by increment and dereference operations on iterator to r and comparison of such iterator to sentinel. Any exception thrown by the evaluation of any argument of reflect_constantei. meta::exception if evaluation of any reflect_constant(ei)evaluation of
reflect_constant or reflect_constant_array would exit via an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomaszkam We can keep the list style if we use the approach used in [string.insert] p10, that means without any introducer before the list and potentially using "Any exception ..." as begin of the first and second item. This has the effect that each bullet item is a full sentence.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it in this manner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Co-authored-by: Daniel Krügler <daniel.kruegler@gmail.com>
|
I would have done 'squash and merge', to avoid an entire page of commits for the one issue :) |
|
Am Do., 27. Nov. 2025 um 19:55 Uhr schrieb Jonathan Wakely <
***@***.***>:
*jwakely* left a comment (cplusplus/LWG#530)
<#530 (comment)>
I would have done 'squash and merge', to avoid an entire page of commits
for the one issue :)
https://github.com/cplusplus/LWG/commits/master/
Is this also possibly when doing commits during the review? I have not
found such an option.
- Daniel
… —
Reply to this email directly, view it on GitHub
<#530 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJKSBQBJU5UQTHNM2IT43365CJBAVCNFSM6AAAAACNLMMWFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKOBXGA2DANZQGU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
It's an option when you do the final merge. Click the drop-down arrow next to the merge button and choose squash and merge |
|
Great, thank you for the tip! |

…lect_constant_array and related functions